Messages in this thread | | | Subject | Re: [PATCH 03/13] mtd: spinand: Setup spi_mem_op for the SPI IO protocol using reg_proto | From | Apurva Nandan <> | Date | Fri, 20 Aug 2021 15:22:54 +0530 |
| |
Hi Miquèl,
On 07/08/21 12:00 am, Miquel Raynal wrote: > Hi Apurva, > > Apurva Nandan <a-nandan@ti.com> wrote on Tue, 13 Jul 2021 13:05:28 > +0000: > >> Currently, the op macros in spinand.h don't give the option to setup >> any non-array access instructions for Dual/Quad/Octal DTR SPI bus. >> Having a function that setups the op based on reg_proto would be >> better than trying to write all the setup logic in op macros. >> >> Create a spimem_setup_op() that would setup cmd, addr, dummy and data >> phase of the spi_mem op, for the given spinand->reg_proto. And hence, >> call the spimem_setup_op() before executing any spi_mem op. >> >> Note: In this commit, spimem_setup_op() isn't called in the >> read_reg_op(), write_reg_op() and wait() functions, as they need >> modifications in address value and data nbytes when in Octal DTR mode. >> This will be fixed in a later commit. > > Thanks for this series! > > So far I am fine with your changes, but I don't like the setup_op() > naming much. I don't yet have a better idea, could you propose > something more meaningful? >
I made this similar to the spi_nor_spimem_setup_op(), which essentially does the same task as this in the spi-nor core.
Other names that I can think of are:
- config_op(), adjust_op(), amend_op(), patch_op()
or
- handle_op_variations(), apply_op_variations()
What do you suggest?
>> Signed-off-by: Apurva Nandan <a-nandan@ti.com> > > Thanks, > Miquèl > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > Thanks, Apurva Nandan
| |