Messages in this thread | | | Date | Mon, 2 Aug 2021 16:13:27 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault() |
| |
On Sat, Jul 31, 2021 at 12:26:37PM -0700, Luigi Rizzo wrote: > amd_iommu_report_page_fault() has two print paths, depending on whether or > not it can find a pci device. But the code erroneously enters the second > path if the rate limiter in the first path triggers: > if (dev_data && ratelimit(A)) { A; } else if (ratelimit(B)) { B; } > The correct code should be > if (dev_data) { if (ratelimit(A)) { A;} } else if (ratelimit(B)) { B; } > > Signed-off-by: Luigi Rizzo <lrizzo@google.com> > --- > drivers/iommu/amd/iommu.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-)
Thanks, but I queued this patch already:
https://lore.kernel.org/r/YPgk1dD1gPMhJXgY@wantstofly.org
Regards,
Joerg
| |