Messages in this thread | | | Date | Mon, 2 Aug 2021 11:23:26 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v7 1/6] mfd: sy7636a: Initial commit |
| |
On Mon, 02 Aug 2021, Alistair Francis wrote:
> On Wed, Jul 21, 2021 at 12:53 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Thu, 08 Jul 2021, Alistair Francis wrote: > > > > > Initial support for the Silergy SY7636A Power Management chip. > > > > > > Signed-off-by: Alistair Francis <alistair@alistair23.me> > > > --- > > > drivers/mfd/Kconfig | 9 +++++ > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/sy7636a.c | 81 +++++++++++++++++++++++++++++++++++++ > > > include/linux/mfd/sy7636a.h | 47 +++++++++++++++++++++ > > > 4 files changed, 138 insertions(+) > > > create mode 100644 drivers/mfd/sy7636a.c > > > create mode 100644 include/linux/mfd/sy7636a.h
[...]
> > > +struct sy7636a { > > > + struct device *dev; > > > + struct regmap *regmap; > > > + struct gpio_desc *pgood_gpio; > > > > This looks unused? > > It is used in the syy636a-regulator
If it's only used in one driver, please declare it there.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |