lkml.org 
[lkml]   [2021]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] usb: misc: chaoskey: get lock before calling usb_[disable|enable]_autosuspend()
Based on the documentation of usb_[disable|enable]_autosuspend(), the
caller must hold udev's device lock.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
drivers/usb/misc/chaoskey.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/misc/chaoskey.c b/drivers/usb/misc/chaoskey.c
index 87067c3d6109..8af00be7b9e8 100644
--- a/drivers/usb/misc/chaoskey.c
+++ b/drivers/usb/misc/chaoskey.c
@@ -206,7 +206,9 @@ static int chaoskey_probe(struct usb_interface *interface,
if (!dev->hwrng_registered)
usb_err(interface, "Unable to register with hwrng");

+ usb_lock_device(udev);
usb_enable_autosuspend(udev);
+ usb_unlock_device(udev);

usb_dbg(interface, "chaoskey probe success, size %d", dev->size);
return 0;
--
2.25.1
\
 
 \ /
  Last update: 2021-08-03 00:22    [W:0.039 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site