Messages in this thread | | | From | Ramji Jiyani <> | Date | Mon, 2 Aug 2021 15:08:51 -0700 | Subject | Re: [PATCH] binder: Add invalid handle info in user error log |
| |
On Mon, Aug 2, 2021 at 11:22 AM Todd Kjos <tkjos@google.com> wrote: > > On Mon, Aug 2, 2021 at 10:41 AM 'Ramji Jiyani' via kernel-team > <kernel-team@android.com> wrote: > > > > In case of a fail transaction to the target node; user error log currently > > nit: I'd rephrase this to something like "In the case of a failed > transaction, only the thread and process id are logged. Add the handle > info..."
Thanks for the review. Submitted v2 with the fix.
> > > only prints the thread and process id. Add handle info for the reference > > to the target node in user error log to aid debugging. > > > > Signed-off-by: Ramji Jiyani <ramjiyani@google.com> > > Acked-by: Todd Kjos <tkjos@google.com>
Thanks for the Ack.
> > > --- > > drivers/android/binder.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > > index bcec598b89f2..d9030cb6b1e4 100644 > > --- a/drivers/android/binder.c > > +++ b/drivers/android/binder.c > > @@ -2547,8 +2547,8 @@ static void binder_transaction(struct binder_proc *proc, > > ref->node, &target_proc, > > &return_error); > > } else { > > - binder_user_error("%d:%d got transaction to invalid handle\n", > > - proc->pid, thread->pid); > > + binder_user_error("%d:%d got transaction to invalid handle, %u\n", > > + proc->pid, thread->pid, tr->target.handle); > > return_error = BR_FAILED_REPLY; > > } > > binder_proc_unlock(proc); > > -- > > 2.32.0.554.ge1b32706d8-goog > > > > -- > > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. > >
| |