Messages in this thread | | | Subject | Re: [RFC PATCH v2 00/69] KVM: X86: TDX support | From | Paolo Bonzini <> | Date | Mon, 2 Aug 2021 09:33:08 +0200 |
| |
On 28/07/21 18:51, Sean Christopherson wrote: > I strongly object to merging these two until we see the new SEAMLDR code: > > [RFC PATCH v2 02/69] KVM: X86: move kvm_cpu_vmxon() from vmx.c to virtext.h > [RFC PATCH v2 03/69] KVM: X86: move out the definition vmcs_hdr/vmcs from kvm to x86 > > If the SEAMLDR code ends up being fully contained in KVM, then this is unnecessary > churn and exposes code outside of KVM that we may not want exposed (yet). E.g. > setting and clearing CR4.VMXE (in the fault path) in cpu_vmxon() may not be > necessary/desirable for SEAMLDR, we simply can't tell without seeing the code.
Fair enough (though, for patch 2, it's a bit weird to have vmxoff in virtext.h and not vmxon).
Paolo
| |