Messages in this thread | | | Date | Wed, 18 Aug 2021 23:32:14 -0700 | From | Kees Cook <> | Subject | Re: [PATCH 07/13] kbuild: do not remove 'linux' link in scripts/link-vmlinux.sh |
| |
On Thu, Aug 19, 2021 at 09:57:38AM +0900, Masahiro Yamada wrote: > arch/um/Makefile passes the -f option to the ln command: > > $(Q)ln -f $< $@ > > So, the hard link is always re-created, and the old one is removed > anyway.
Hah, yeah, that's a bit of ARCH=um redundancy.
Reviewed-by: Kees Cook <keescook@chromium.org>
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > scripts/link-vmlinux.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh > index a6c4d0bce3ba..7b9c62e4d54a 100755 > --- a/scripts/link-vmlinux.sh > +++ b/scripts/link-vmlinux.sh > @@ -206,7 +206,6 @@ vmlinux_link() > -Wl,-T,${lds} \ > ${objects} \ > -lutil -lrt -lpthread > - rm -f linux > fi > } > > -- > 2.30.2 >
-- Kees Cook
| |