Messages in this thread | | | Subject | Re: [PATCH] drm/bridge/tc358767: make the array ext_div static const, makes object smaller | From | Joe Perches <> | Date | Thu, 19 Aug 2021 08:10:23 -0700 |
| |
On Thu, 2021-08-19 at 15:51 +0100, Colin Ian King wrote:
> it still makes sense for these kind of > janitorial changes as it makes sense to constify arrays when they are > read-only and making them static is sensible for const data.
I'm not disagreeing. Marking unmodifiable arrays as const is generally useful for readers. Decent compilers though can _mostly_ determine whether or not an array is used as const and whether the array can be placed in a readonly section and is not required to be in a writable one.
But the object sizes deltas you show with an allmodconfig are misleading. At a minimum I think you should show the output sizes as allmodconfig.
| |