Messages in this thread | | | From | Xiaoliang Yang <> | Subject | RE: [RFC v2 net-next 3/8] net: mscc: ocelot: set vcap IS2 chain to goto PSFP chain | Date | Thu, 19 Aug 2021 09:49:54 +0000 |
| |
On Wed, Aug 18, 2021 at 22:55:23PM +0800, Vladimir Oltean wrote: > > @@ -353,7 +364,7 @@ static int ocelot_flower_parse_action(struct > > ocelot *ocelot, int port, > > > > if (filter->goto_target == -1) { > > if ((filter->block_id == VCAP_IS2 && filter->lookup == 1) || > > - chain == 0) { > > + chain == 0 || filter->block_id == PSFP_BLOCK_ID) { > > allow_missing_goto_target = true; > > I would like to not allow missing "goto" targets for new filter chains. > > Due to legacy support we must keep support for VCAP IS2 on chain 0, but ever > since we added the ability to offload multiple chains corresponding to multiple > hardware blocks, we should really use that precise chain ID, and chain 0 should > just goto the first used chain in the pipeline. > > Makes sense? > Because the PSFP chain is the last chain now, I allow missing "goto" targets. Once we add a new chain like FRER, I will delete this allow missing "goto" for PSFP block chain.
Thanks, Xiaoliang
| |