Messages in this thread | | | From | Vlad Buslov <> | Subject | Re: [PATCH][linux-next] net/mlx5: Bridge, fix uninitialized variable in mlx5_esw_bridge_port_changeupper() | Date | Wed, 18 Aug 2021 19:47:55 +0300 |
| |
On Wed 18 Aug 2021 at 18:52, Tim Gardner <tim.gardner@canonical.com> wrote: > A recent change removed code that initialized the return code variable 'err'. It > is now possible for mlx5_esw_bridge_port_changeupper() to return an error code > using this uninitialized variable. Fix it by initializing to 0. > > Addresses-Coverity: ("Uninitialized scalar variable (UNINIT)") > > Cc: Saeed Mahameed <saeedm@nvidia.com> > Cc: Leon Romanovsky <leon@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Vlad Buslov <vladbu@nvidia.com> > Cc: Jianbo Liu <jianbol@nvidia.com> > Cc: Mark Bloch <mbloch@nvidia.com> > Cc: Roi Dayan <roid@nvidia.com> > Cc: Vladimir Oltean <vladimir.oltean@nxp.com> > Cc: netdev@vger.kernel.org > Cc: linux-rdma@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > ---
Tim, thanks for fixing this!
Saeed, this is the second similar issue that I mentioned in my reply to Colin. Again, I've already submitted same patch internally and this one is as good as mine.
Reviewed-by: Vlad Buslov <vladbu@nvidia.com>
[...]
| |