lkml.org 
[lkml]   [2021]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/2] mm: hwpoison: don't drop slab caches for offlining non-LRU page
Date
On Wed, Aug 18, 2021 at 09:24:01AM +0200, David Hildenbrand wrote:
...
>
> Might we want to add a TODO in the code? We have a similar one in
> mm/page_isolation.c:set_migratetype_isolate() and it's certainly a reminder
> that something of value is missing.

Yes, that will be helpful. The below's what's in my mind, but if someone
has better idea, that's fine.

@@ -296,11 +296,9 @@ void shake_page(struct page *p, int access)
}

/*
- * Only call shrink_node_slabs here (which would also shrink
- * other caches) if access is not potentially fatal.
+ * TODO: Could shrink slab caches here if a lightweight range-based
+ * shrinker will be available.
*/
- if (access)
- drop_slab_node(page_to_nid(p));
}
EXPORT_SYMBOL_GPL(shake_page);


- Naoya Horiguchi
\
 
 \ /
  Last update: 2021-08-18 09:55    [W:0.081 / U:1.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site