Messages in this thread | | | Subject | Re: [PATCH v3] staging: r8188eu: Remove unused including <linux/version.h> | From | Michael Straube <> | Date | Wed, 18 Aug 2021 08:40:05 +0200 |
| |
On 8/18/21 8:36 AM, Cai Huoqing wrote: > Remove including <linux/version.h> that don't need it > > v1->v2: remove "based on staging-next" from commit message > v2->v3: add changelog to commit message
You should put the v1->v2 lines below the --- line, so it will not appear in the final commit message.
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > ---
--> here
> drivers/staging/r8188eu/core/rtw_mlme.c | 1 - > drivers/staging/r8188eu/os_dep/os_intfs.c | 1 - > drivers/staging/r8188eu/os_dep/rtw_android.c | 1 - > drivers/staging/r8188eu/os_dep/xmit_linux.c | 1 - > 4 files changed, 4 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c > index d5ef5783f4ad..82b74ebdaabd 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c > @@ -3,7 +3,6 @@ > > #define _RTW_MLME_C_ > > -#include <linux/version.h> > #include "../include/osdep_service.h" > #include "../include/drv_types.h" > #include "../include/recv_osdep.h" > diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c > index f4bf4732578a..aef978eef4d7 100644 > --- a/drivers/staging/r8188eu/os_dep/os_intfs.c > +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c > @@ -12,7 +12,6 @@ > > #include "../include/usb_osintf.h" > #include "../include/rtw_br_ext.h" > -#include <linux/version.h> > > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Realtek Wireless Lan Driver"); > diff --git a/drivers/staging/r8188eu/os_dep/rtw_android.c b/drivers/staging/r8188eu/os_dep/rtw_android.c > index bdd381606ba6..af0072e2cb5f 100644 > --- a/drivers/staging/r8188eu/os_dep/rtw_android.c > +++ b/drivers/staging/r8188eu/os_dep/rtw_android.c > @@ -3,7 +3,6 @@ > > #include <linux/module.h> > #include <linux/netdevice.h> > -#include <linux/version.h> > #include "../include/rtw_android.h" > #include "../include/osdep_service.h" > #include "../include/rtw_debug.h" > diff --git a/drivers/staging/r8188eu/os_dep/xmit_linux.c b/drivers/staging/r8188eu/os_dep/xmit_linux.c > index 4f1ce346b3a5..69966c696130 100644 > --- a/drivers/staging/r8188eu/os_dep/xmit_linux.c > +++ b/drivers/staging/r8188eu/os_dep/xmit_linux.c > @@ -3,7 +3,6 @@ > > #define _XMIT_OSDEP_C_ > > -#include <linux/version.h> > #include "../include/osdep_service.h" > #include "../include/drv_types.h" > #include "../include/if_ether.h" >
Thanks, Michael
| |