Messages in this thread Patch in this message | | | Date | Wed, 18 Aug 2021 19:56:59 -0000 | From | "irqchip-bot for Jianqun Xu" <> | Subject | [irqchip: irq/irqchip-next] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type |
| |
The following commit has been merged into the irq/irqchip-next branch of irqchip:
Commit-ID: 93103f6eb09ca5152ef9173ec8b91b78df1905e8 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/93103f6eb09ca5152ef9173ec8b91b78df1905e8 Author: Jianqun Xu <jay.xu@rock-chips.com> AuthorDate: Mon, 16 Aug 2021 09:21:35 +08:00 Committer: Linus Walleij <linus.walleij@linaro.org> CommitterDate: Tue, 17 Aug 2021 01:01:50 +02:00
gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock.
Reviewed-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com> Link: https://lore.kernel.org/r/20210816012135.1119234-1-jay.xu@rock-chips.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index b2be560..036b2d9 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret;
| |