Messages in this thread | | | From | Paulo Alcantara <> | Subject | Re: [PATCH] CIFS: Fix a potencially linear read overflow | Date | Tue, 17 Aug 2021 21:28:40 -0300 |
| |
Len Baker <len.baker@gmx.com> writes:
> strlcpy() reads the entire source buffer first. This read may exceed the > destination size limit. This is both inefficient and can lead to linear > read overflows if a source string is not NUL-terminated. > > Also, the strnlen() call does not avoid the read overflow in the strlcpy > function when a not NUL-terminated string is passed. > > So, replace this block by a call to kstrndup() that avoids this type of > overflow and does the same. > > Fixes: 066ce6899484d ("cifs: rename cifs_strlcpy_to_host and make it use new functions") > Signed-off-by: Len Baker <len.baker@gmx.com> > --- > fs/cifs/cifs_unicode.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-)
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
| |