Messages in this thread | | | Subject | Re: [PATCH v2 2/3] staging: r8188eu: remove unneeded DBG_88E call from rtl8188e_Add_RateATid | From | Michael Straube <> | Date | Tue, 17 Aug 2021 09:02:39 +0200 |
| |
On 8/17/21 1:44 AM, Phillip Potter wrote: > Remove unneeded DBG_88E macro call from the rtl8188e_Add_RateATid > function in hal/rtl8188e_cmd.c, as it is not particularly clear in my > opinion, and we should strive towards use of existing kernel machinery > for debugging purposes. > > Signed-off-by: Phillip Potter <phil@philpotter.co.uk> > --- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > index 4302054c6c83..77c057e276a5 100644 > --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c > @@ -173,9 +173,6 @@ void rtl8188e_Add_RateATid(struct adapter *pAdapter, u32 bitmap, u8 arg, u8 rssi > > bitmap &= 0x0fffffff; > > - DBG_88E("%s=> mac_id:%d, raid:%d, ra_bitmap=0x%x, shortGIrate=0x%02x\n", > - __func__, macid, raid, bitmap, shortGIrate); > - > ODM_RA_UpdateRateInfo_8188E(&haldata->odmpriv, macid, raid, bitmap, shortGIrate); > } > >
Looks good to me.
Acked-by: Michael Straube <straube.linux@gmail.com>
Thanks, Michael
| |