lkml.org 
[lkml]   [2021]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref
On Fri, Aug 13, 2021 at 11:51 PM Liam Beguin <liambeguin@gmail.com> wrote:
> On Mon Aug 9, 2021 at 3:42 PM EDT, Jonathan Cameron wrote:

...

> > > > > + /* Read channel specific information form the devicetree */

from

> > > > > + device_for_each_child_node(dev, child) {
> > > > > + ret = fwnode_property_read_u32(child, "reg", &i);
> > > > > + if (ret) {
> > > > > + dev_err(dev, "missing reg property in %pfw\n", child);
> > > > > + fwnode_handle_put(child);
> > > > > + return ret;
> > > > > + }
> > > > > +
> > > > > + ad7949_chan = &ad7949_adc->channels[i];
> > > > > +
> > > > > + ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
> > > > > + if (ret < 0 && ret != -EINVAL) {
> > > > > + dev_err(dev, "invalid internal reference in %pfw\n", child);
> > > > > + fwnode_handle_put(child);
> > > > > + return ret;
> > > > > + }

> After getting access to another setup to run more tests, I noticed
> that setting the reference per channel isn't really feasible.

Is it a hardware limitation?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-08-16 10:08    [W:0.120 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site