Messages in this thread | | | Date | Mon, 16 Aug 2021 15:53:46 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] net: xfrm: fix bug in ipcomp_free_scratches |
| |
On Mon, Aug 16, 2021 at 03:38:29PM +0800, Dongliang Mu wrote: > > - for_each_possible_cpu(i) > - vfree(*per_cpu_ptr(scratches, i)); > + for_each_possible_cpu(i) { > + void *scratch = *per_cpu_ptr(scratches, i); > + if (!scratch) > + vfree(scratch); > + }
This patch is unnecessary. Please check the implementation of vfree, it already checks for NULL pointers just like most of our free primitives.
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |