lkml.org 
[lkml]   [2021]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()
Applied.  Thanks!

Alex

On Mon, Aug 16, 2021 at 3:23 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 15.08.21 um 21:29 schrieb Nathan Chancellor:
> > Clang + -Wimplicit-fallthrough warns:
> >
> > drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated
> > fall-through between switch labels [-Wimplicit-fallthrough]
> > default:
> > ^
> > drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid
> > fall-through
> > default:
> > ^
> > break;
> > 1 warning generated.
> >
> > Clang's version of this warning is a little bit more pedantic than
> > GCC's. Add the missing break to satisfy it to match what has been done
> > all over the kernel tree.
> >
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > drivers/gpu/drm/radeon/radeon_fb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c
> > index 0b206b052972..c8b545181497 100644
> > --- a/drivers/gpu/drm/radeon/radeon_fb.c
> > +++ b/drivers/gpu/drm/radeon/radeon_fb.c
> > @@ -167,6 +167,7 @@ static int radeonfb_create_pinned_object(struct radeon_fbdev *rfbdev,
> > break;
> > case 2:
> > tiling_flags |= RADEON_TILING_SWAP_16BIT;
> > + break;
> > default:
> > break;
> > }
> >
> > base-commit: ba31f97d43be41ca99ab72a6131d7c226306865f
>

\
 
 \ /
  Last update: 2021-08-16 20:55    [W:0.502 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site