lkml.org 
[lkml]   [2021]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 07/19] ARC: mm: pmd_populate* to use the canonical set_pmd (and drop pmd_set)
    Date
    Signed-off-by: Vineet Gupta <vgupta@kernel.org>
    ---
    arch/arc/include/asm/pgalloc.h | 14 ++++++++++----
    arch/arc/include/asm/pgtable.h | 6 ------
    2 files changed, 10 insertions(+), 10 deletions(-)

    diff --git a/arch/arc/include/asm/pgalloc.h b/arch/arc/include/asm/pgalloc.h
    index a32ca3104ced..408bc4b0842d 100644
    --- a/arch/arc/include/asm/pgalloc.h
    +++ b/arch/arc/include/asm/pgalloc.h
    @@ -35,13 +35,19 @@
    static inline void
    pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd, pte_t *pte)
    {
    - pmd_set(pmd, pte);
    + /*
    + * The cast to long below is OK in 32-bit PAE40 regime with long long pte
    + * Despite "wider" pte, the pte table needs to be in non-PAE low memory
    + * as all higher levels can only hold long pointers.
    + *
    + * The cast itself is needed given simplistic definition of set_pmd()
    + */
    + set_pmd(pmd, __pmd((unsigned long)pte));
    }

    -static inline void
    -pmd_populate(struct mm_struct *mm, pmd_t *pmd, pgtable_t ptep)
    +static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd, pgtable_t pte)
    {
    - pmd_set(pmd, (pte_t *) ptep);
    + set_pmd(pmd, __pmd((unsigned long)pte));
    }

    static inline int __get_order_pgd(void)
    diff --git a/arch/arc/include/asm/pgtable.h b/arch/arc/include/asm/pgtable.h
    index b054c14f8bf6..f762bacb2358 100644
    --- a/arch/arc/include/asm/pgtable.h
    +++ b/arch/arc/include/asm/pgtable.h
    @@ -222,12 +222,6 @@ extern char empty_zero_page[PAGE_SIZE];
    /* find the logical addr (phy for ARC) of the Page Tbl ref by PMD entry */
    #define pmd_page_vaddr(pmd) (pmd_val(pmd) & PAGE_MASK)

    -/* In a 2 level sys, setup the PGD entry with PTE value */
    -static inline void pmd_set(pmd_t *pmdp, pte_t *ptep)
    -{
    - pmd_val(*pmdp) = (unsigned long)ptep;
    -}
    -
    #define pte_none(x) (!pte_val(x))
    #define pte_present(x) (pte_val(x) & _PAGE_PRESENT)
    #define pte_clear(mm, addr, ptep) set_pte_at(mm, addr, ptep, __pte(0))
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-08-13 01:38    [W:2.310 / U:0.856 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site