Messages in this thread | | | Date | Tue, 10 Aug 2021 17:39:41 +0200 | From | Guillaume Nault <> | Subject | Re: [PATCH] ppp: Add rtnl attribute IFLA_PPP_UNIT_ID for specifying ppp unit id |
| |
On Mon, Aug 09, 2021 at 09:31:09PM +0200, Pali Rohár wrote: > Better to wait. I would like hear some comments / review on this patch > if this is the correct approach as it adds a new API/ABI for userspace.
Personally I don't understand the use case for setting the ppp unit at creation time. I didn't implement it on purpose when creating the netlink interface, as I didn't have any use case.
On the other hand, adding the ppp unit in the netlink dump is probably useful.
| |