lkml.org 
[lkml]   [2021]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] PM: domains: Don't attach a device to genpd that corresponds to a provider
Hi Ulf,

Thanks for your patch!

On Fri, Jul 9, 2021 at 2:56 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> According to the common power domain DT bindings, a power domain provider
> must have a "#power-domain-cells" property in its OF node. Additionally, if
> a provider has a "power-domains" property, it means that it has a parent
> domain.

OK.

> It has turned out that some OF nodes that represents a genpd provider may
> also be compatible with a regular platform device. This leads to, during
> probe, genpd_dev_pm_attach(), genpd_dev_pm_attach_by_name() and
> genpd_dev_pm_attach_by_id() tries to attach the corresponding struct device
> to the genpd provider's parent domain, which is wrong. Instead the genpd

Why is that wrong?

> provider should only assign a parent domain, through
> pm_genpd_add_subdomain() or of_genpd_add_subdomain().

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2021-07-09 15:09    [W:0.080 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site