lkml.org 
[lkml]   [2021]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] media: venus: venc: Fix potential null pointer dereference on pointer fmt
    Date
    From: Colin Ian King <colin.king@canonical.com>

    Currently the call to find_format can potentially return a NULL to
    fmt and the nullpointer is later dereferenced on the assignment of
    pixmp->num_planes = fmt->num_planes. Fix this by adding a NULL pointer
    check and returning NULL for the failure case.

    Addresses-Coverity: ("Dereference null return")
    Fixes: aaaa93eda64b ("[media] media: venus: venc: add video encoder files")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    drivers/media/platform/qcom/venus/venc.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
    index 8dd49d4f124c..1d62e38065d6 100644
    --- a/drivers/media/platform/qcom/venus/venc.c
    +++ b/drivers/media/platform/qcom/venus/venc.c
    @@ -183,6 +183,8 @@ venc_try_fmt_common(struct venus_inst *inst, struct v4l2_format *f)
    else
    return NULL;
    fmt = find_format(inst, pixmp->pixelformat, f->type);
    + if (!fmt)
    + return NULL;
    }

    pixmp->width = clamp(pixmp->width, frame_width_min(inst),
    --
    2.31.1
    \
     
     \ /
      Last update: 2021-07-09 14:33    [W:6.116 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site