lkml.org 
[lkml]   [2021]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] libperf: Move idx to perf_evsel::idx
On Wed, Jul 07, 2021 at 02:48:04PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 07, 2021 at 11:49:03AM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Tue, Jul 06, 2021 at 05:16:59PM +0200, Jiri Olsa escreveu:
> > > Moving evsel::idx to perf_evsel::idx, so we can move
> > > the group interface to libperf.
>
> You forgot these:
>
> $ find tools/perf/ -name "*.[ch]" | xargs grep 'evsel->idx'
> tools/perf/ui/gtk/annotate.c: evsel->idx + i);
> tools/perf/ui/gtk/annotate.c: evsel->idx);
> $

aaah we still have that :-) thanks

as I wrote earlier, I'll take what you have in tmp.perf/core and go from
there with your changes

thanks,
jirka

>
> That running 'make -C tools/perf build-test' caught, so I'm adding this
> to this patch as well:
>
> diff --git a/tools/perf/ui/gtk/annotate.c b/tools/perf/ui/gtk/annotate.c
> index a7dff77f20184f1f..c266ed4fa015842d 100644
> --- a/tools/perf/ui/gtk/annotate.c
> +++ b/tools/perf/ui/gtk/annotate.c
> @@ -135,12 +135,12 @@ static int perf_gtk__annotate_symbol(GtkWidget *window, struct map_symbol *ms,
> ret += perf_gtk__get_percent(s + ret,
> sizeof(s) - ret,
> sym, pos,
> - evsel->idx + i);
> + evesl->core.idx + i);
> ret += scnprintf(s + ret, sizeof(s) - ret, " ");
> }
> } else {
> ret = perf_gtk__get_percent(s, sizeof(s), sym, pos,
> - evsel->idx);
> + evesl->core.idx);
> }
>
> if (ret)
>

\
 
 \ /
  Last update: 2021-07-07 20:20    [W:2.502 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site