lkml.org 
[lkml]   [2021]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/12] ASoC: amd: create acp5x platform devices
On Wed, Jul 07, 2021 at 11:26:15AM +0530, Vijendar Mukunda wrote:

> +#define I2S_MODE 0x00
> +#define ACP5x_I2S_MODE 0x00

All the other constants are namespaced so why the plain I2S_MODE?

> + val = acp_readl(adata->acp5x_base + ACP_PIN_CONFIG);
> + switch (val) {
> + case I2S_MODE:

...

> + break;
> + default:
> + dev_info(&pci->dev, "ACP audio mode : %d\n", val);
> + }

Given that anything other than I2S is basically unhandled should we
perhaps print an error rather than just an info message?
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-07-07 18:23    [W:0.066 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site