lkml.org 
[lkml]   [2021]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mm: try_to_unmap() is now void
Date
Fix the "CONFIG_MMU is not set" case of converting
try_to_unmap() from bool to void.
(as seen on m68k/coldfire)

In file included from ../mm/vmscan.c:33:
../mm/vmscan.c: In function 'shrink_page_list':
../include/linux/rmap.h:294:34: warning: statement with no effect [-Wunused-value]
294 | #define try_to_unmap(page, refs) false
| ^~~~~
../mm/vmscan.c:1508:4: note: in expansion of macro 'try_to_unmap'
1508 | try_to_unmap(page, flags);
| ^~~~~~~~~~~~

Fixes: 1fb08ac63bee ("mm: rmap: make try_to_unmap() void function")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yang Shi <shy828301@gmail.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Cc: Greg Ungerer <gerg@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Cc: uclinux-dev@uclinux.org
---
v2: add linux-mm m.l.
add M68K/Coldfire Cc's
change to static inline function.

include/linux/rmap.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-next-20210701.orig/include/linux/rmap.h
+++ linux-next-20210701/include/linux/rmap.h
@@ -291,7 +291,8 @@ static inline int page_referenced(struct
return 0;
}

-#define try_to_unmap(page, refs) false
+static inline void try_to_unmap(struct page *page, enum ttu_flags flags)
+{}

static inline int page_mkclean(struct page *page)
{
\
 
 \ /
  Last update: 2021-07-07 18:17    [W:0.032 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site