lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 021/137] drm/virtio: Fixes a potential NULL pointer dereference on probe failure
    Date
    From: Xie Yongji <xieyongji@bytedance.com>

    [ Upstream commit 17f46f488a5d82c5568e6e786cd760bba1c2ee09 ]

    The dev->dev_private might not be allocated if virtio_gpu_pci_quirk()
    or virtio_gpu_init() failed. In this case, we should avoid the cleanup
    in virtio_gpu_release().

    Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/20210517084913.403-1-xieyongji@bytedance.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/virtio/virtgpu_kms.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c
    index eed57a931309..5e716199ccee 100644
    --- a/drivers/gpu/drm/virtio/virtgpu_kms.c
    +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c
    @@ -239,6 +239,9 @@ void virtio_gpu_release(struct drm_device *dev)
    {
    struct virtio_gpu_device *vgdev = dev->dev_private;

    + if (!vgdev)
    + return;
    +
    virtio_gpu_modeset_fini(vgdev);
    virtio_gpu_free_vbufs(vgdev);
    virtio_gpu_cleanup_cap_cache(vgdev);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 14:39    [W:2.573 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site