lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 09/74] atm: iphase: fix possible use-after-free in ia_module_exit()
    Date
    From: Zou Wei <zou_wei@huawei.com>

    [ Upstream commit 1c72e6ab66b9598cac741ed397438a52065a8f1f ]

    This module's remove path calls del_timer(). However, that function
    does not wait until the timer handler finishes. This means that the
    timer handler may still be running after the driver's remove function
    has finished, which would result in a use-after-free.

    Fix by calling del_timer_sync(), which makes sure the timer handler
    has finished, and unable to re-schedule itself.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Zou Wei <zou_wei@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/atm/iphase.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
    index 8c7a996d1f16..46990352b5d3 100644
    --- a/drivers/atm/iphase.c
    +++ b/drivers/atm/iphase.c
    @@ -3295,7 +3295,7 @@ static void __exit ia_module_exit(void)
    {
    pci_unregister_driver(&ia_driver);

    - del_timer(&ia_timer);
    + del_timer_sync(&ia_timer);
    }

    module_init(ia_module_init);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 14:39    [W:5.907 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site