lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 050/160] drm: bridge: cdns-mhdp8546: Fix PM reference leak in
    Date
    From: Yu Kuai <yukuai3@huawei.com>

    [ Upstream commit f674555ee5444c8987dfea0922f1cf6bf0c12847 ]

    pm_runtime_get_sync will increment pm usage counter even it failed.
    Forgetting to putting operation will result in reference leak here.
    Fix it by replacing it with pm_runtime_resume_and_get to keep usage
    counter balanced.

    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    Reviewed-by: Robert Foss <robert.foss@linaro.org>
    Signed-off-by: Robert Foss <robert.foss@linaro.org>
    Link: https://patchwork.freedesktop.org/patch/msgid/20210531135622.3348252-1-yukuai3@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
    index d0c65610ebb5..f56ff97c9899 100644
    --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
    +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
    @@ -2369,9 +2369,9 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
    clk_prepare_enable(clk);

    pm_runtime_enable(dev);
    - ret = pm_runtime_get_sync(dev);
    + ret = pm_runtime_resume_and_get(dev);
    if (ret < 0) {
    - dev_err(dev, "pm_runtime_get_sync failed\n");
    + dev_err(dev, "pm_runtime_resume_and_get failed\n");
    pm_runtime_disable(dev);
    goto clk_disable;
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 14:10    [W:2.237 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site