lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 085/160] fjes: check return value after calling platform_get_resource()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit f18c11812c949553d2b2481ecaa274dd51bed1e7 ]

    It will cause null-ptr-deref if platform_get_resource() returns NULL,
    we need check the return value.

    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/fjes/fjes_main.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
    index 466622664424..e449d9466122 100644
    --- a/drivers/net/fjes/fjes_main.c
    +++ b/drivers/net/fjes/fjes_main.c
    @@ -1262,6 +1262,10 @@ static int fjes_probe(struct platform_device *plat_dev)
    adapter->interrupt_watch_enable = false;

    res = platform_get_resource(plat_dev, IORESOURCE_MEM, 0);
    + if (!res) {
    + err = -EINVAL;
    + goto err_free_control_wq;
    + }
    hw->hw_res.start = res->start;
    hw->hw_res.size = resource_size(res);
    hw->hw_res.irq = platform_get_irq(plat_dev, 0);
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 13:40    [W:4.579 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site