lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC v2 12/34] mm, slub: move disabling/enabling irqs to ___slab_alloc()
From
Date
Greetings,

On Wed, 2021-06-09 at 13:38 +0200, Vlastimil Babka wrote:
> @@ -3313,6 +3320,8 @@ int kmem_cache_alloc_bulk(struct kmem_cache *s,
> gfp_t flags, size_t size,
> */
> c->tid = next_tid(c->tid);
>
> + local_irq_enable();
> +
> /*
> * Invoking slow path likely have side-effect
> * of re-populating per CPU c->freelist

This addition should have been followed by removal of the one in the
error path. At the end of the series, RT ends up doing a double
local_unlock_irq() instead of post ___slab_alloc() slub_put_cpu_ptr().

-Mike

\
 
 \ /
  Last update: 2021-07-06 06:39    [W:5.562 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site