lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.13 009/189] drm/vc4: fix argument ordering in vc4_crtc_get_margins()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit e590c2b03a6143ba93ddad306bc9eaafa838c020 ]

    Cppcheck complains that the declaration doesn't match the function
    definition. Obviously "left" should come before "right". The caller
    and the function implementation are done this way, it's just the
    declaration which is wrong so this doesn't affect runtime.

    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    Link: https://patchwork.freedesktop.org/patch/msgid/YH/720FD978TPhHp@mwanda
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vc4/vc4_drv.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
    index a7500716cf3f..5dceadc61600 100644
    --- a/drivers/gpu/drm/vc4/vc4_drv.h
    +++ b/drivers/gpu/drm/vc4/vc4_drv.h
    @@ -825,7 +825,7 @@ void vc4_crtc_destroy_state(struct drm_crtc *crtc,
    void vc4_crtc_reset(struct drm_crtc *crtc);
    void vc4_crtc_handle_vblank(struct vc4_crtc *crtc);
    void vc4_crtc_get_margins(struct drm_crtc_state *state,
    - unsigned int *right, unsigned int *left,
    + unsigned int *left, unsigned int *right,
    unsigned int *top, unsigned int *bottom);

    /* vc4_debugfs.c */
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 13:15    [W:2.407 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site