lkml.org 
[lkml]   [2021]   [Jul]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/4] s390/ccwgroup: Drop if with an always false condition
    Date
    The driver core only calls a bus remove callback when there is a driver.
    So dev->driver is never NULL and the check can safely be removed.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    ---
    drivers/s390/cio/ccwgroup.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/s390/cio/ccwgroup.c b/drivers/s390/cio/ccwgroup.c
    index 9748165e08e9..a6aeab1ea0ae 100644
    --- a/drivers/s390/cio/ccwgroup.c
    +++ b/drivers/s390/cio/ccwgroup.c
    @@ -444,8 +444,6 @@ static int ccwgroup_remove(struct device *dev)
    struct ccwgroup_device *gdev = to_ccwgroupdev(dev);
    struct ccwgroup_driver *gdrv = to_ccwgroupdrv(dev->driver);

    - if (!dev->driver)
    - return 0;
    if (gdrv->remove)
    gdrv->remove(gdev);

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-06 17:54    [W:3.785 / U:0.692 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site