lkml.org 
[lkml]   [2021]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module
From
Date
On 7/5/21 8:15 AM, Krzysztof Kozlowski wrote:
> On 14/05/2021 16:04, Krzysztof Kozlowski wrote:
>> On 14/05/2021 09:48, Guenter Roeck wrote:
>>> On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
>>>> When rt2880_wdt watchdog driver is built as a module, the
>>>> rt_sysc_membase needs to be exported (it is being used via inlined
>>>> rt_sysc_r32):
>>>>
>>>> ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!
>>>>
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>
>>> Acked-by: Guenter Roeck <linux@roeck-us.net>
>>>
>>> I don't see a recent change in the code. Has that problem been there
>>> all along ?
>>
>> I think the problem was there always but 0-day builder did not hit it
>> until recently:
>> https://lore.kernel.org/lkml/202105082122.yrF7ploN-lkp@intel.com/
>
> Hi Guenter,
>
> It seems that patch was not applied. Anything to fix here?
>
I see commit fef532ea0cd8 ("MIPS: ralink: export rt_sysc_membase for
rt2880_wdt.c"). Does that not solve the problem ?

Guenter

\
 
 \ /
  Last update: 2021-07-05 18:08    [W:1.859 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site