lkml.org 
[lkml]   [2021]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 15/26] platform/x86: toshiba_acpi: Fix missing error code in toshiba_acpi_setup_keyboard()
    Date
    From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

    [ Upstream commit 28e367127718a9cb85d615a71e152f7acee41bfc ]

    The error code is missing in this code scenario, add the error code
    '-EINVAL' to the return value 'error'.

    Eliminate the follow smatch warning:

    drivers/platform/x86/toshiba_acpi.c:2834 toshiba_acpi_setup_keyboard()
    warn: missing error code 'error'.

    Reported-by: Abaci Robot <abaci@linux.alibaba.com>
    Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
    Link: https://lore.kernel.org/r/1622628348-87035-1-git-send-email-jiapeng.chong@linux.alibaba.com
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/toshiba_acpi.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
    index 71a969fc3b20..f202fc0dd1ff 100644
    --- a/drivers/platform/x86/toshiba_acpi.c
    +++ b/drivers/platform/x86/toshiba_acpi.c
    @@ -2841,6 +2841,7 @@ static int toshiba_acpi_setup_keyboard(struct toshiba_acpi_dev *dev)

    if (!dev->info_supported && !dev->system_event_supported) {
    pr_warn("No hotkey query interface found\n");
    + error = -EINVAL;
    goto err_remove_filter;
    }

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-05 17:34    [W:6.199 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site