lkml.org 
[lkml]   [2021]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 04/41] hv_utils: Fix passing zero to 'PTR_ERR' warning
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit c6a8625fa4c6b0a97860d053271660ccedc3d1b3 ]

    Sparse warn this:

    drivers/hv/hv_util.c:753 hv_timesync_init() warn:
    passing zero to 'PTR_ERR'

    Use PTR_ERR_OR_ZERO instead of PTR_ERR to fix this.

    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Link: https://lore.kernel.org/r/20210514070116.16800-1-yuehaibing@huawei.com
    [ wei: change %ld to %d ]
    Signed-off-by: Wei Liu <wei.liu@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hv/hv_util.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
    index 05566ecdbe4b..1b914e418e41 100644
    --- a/drivers/hv/hv_util.c
    +++ b/drivers/hv/hv_util.c
    @@ -696,8 +696,8 @@ static int hv_timesync_init(struct hv_util_service *srv)
    */
    hv_ptp_clock = ptp_clock_register(&ptp_hyperv_info, NULL);
    if (IS_ERR_OR_NULL(hv_ptp_clock)) {
    - pr_err("cannot register PTP clock: %ld\n",
    - PTR_ERR(hv_ptp_clock));
    + pr_err("cannot register PTP clock: %d\n",
    + PTR_ERR_OR_ZERO(hv_ptp_clock));
    hv_ptp_clock = NULL;
    }

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-05 17:32    [W:17.205 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site