lkml.org 
[lkml]   [2021]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 2/7] gpio: mxc: Fix disabled interrupt wake-up support
    Date
    From: Loic Poulain <loic.poulain@linaro.org>

    [ Upstream commit 3093e6cca3ba7d47848068cb256c489675125181 ]

    A disabled/masked interrupt marked as wakeup source must be re-enable
    and unmasked in order to be able to wake-up the host. That can be done
    by flaging the irqchip with IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND.

    Note: It 'sometimes' works without that change, but only thanks to the
    lazy generic interrupt disabling (keeping interrupt unmasked).

    Reported-by: Michal Koziel <michal.koziel@emlogic.no>
    Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
    Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpio/gpio-mxc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
    index 643f4c557ac2..ba6ed2a413f5 100644
    --- a/drivers/gpio/gpio-mxc.c
    +++ b/drivers/gpio/gpio-mxc.c
    @@ -361,7 +361,7 @@ static int mxc_gpio_init_gc(struct mxc_gpio_port *port, int irq_base)
    ct->chip.irq_unmask = irq_gc_mask_set_bit;
    ct->chip.irq_set_type = gpio_set_irq_type;
    ct->chip.irq_set_wake = gpio_set_wake_irq;
    - ct->chip.flags = IRQCHIP_MASK_ON_SUSPEND;
    + ct->chip.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND;
    ct->regs.ack = GPIO_ISR;
    ct->regs.mask = GPIO_IMR;

    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-05 13:00    [W:3.760 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site