lkml.org 
[lkml]   [2021]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks
    > Does that means keystone and Loongson has the same MRRS problem? And what should I do now?

    Look like yes ! and amlogic has the same problem.
    I think somebody need to rewrite it all to one common quirk for this problem.

    If no one has any objection, I can try to remake it again.

    On Fri, Jul 2, 2021 at 9:15 AM 陈华才 <chenhuacai@loongson.cn> wrote:
    >
    > Hi, Bjorn,
    >
    > &gt; -----原始邮件-----
    > &gt; 发件人: "Bjorn Helgaas" <helgaas@kernel.org>
    > &gt; 发送时间: 2021-07-01 23:46:34 (星期四)
    > &gt; 收件人: "Artem Lapkin" <email2tema@gmail.com>
    > &gt; 抄送: narmstrong@baylibre.com, yue.wang@Amlogic.com, khilman@baylibre.com, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, jbrunet@baylibre.com, christianshewitt@gmail.com, martin.blumenstingl@googlemail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, art@khadas.com, nick@khadas.com, gouwa@khadas.com, "Huacai Chen" <chenhuacai@loongson.cn>
    > &gt; 主题: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks
    > &gt;
    > &gt; [+cc Huacai]
    > &gt;
    > &gt; On Sat, Jun 19, 2021 at 02:39:48PM +0800, Artem Lapkin wrote:
    > &gt; &gt; Replace dublicated MRRS limit quirks by mrrs_limit_quirk from core
    > &gt; &gt; * drivers/pci/controller/dwc/pci-keystone.c
    > &gt; &gt; * drivers/pci/controller/pci-loongson.c
    > &gt;
    > &gt; s/dublicated/duplicated/ (several occurrences)
    > &gt;
    > &gt; Capitalize subject lines.
    > &gt;
    > &gt; Use "git log --online" to learn conventions and follow them.
    > &gt;
    > &gt; Add "()" after function names.
    > &gt;
    > &gt; Capitalize acronyms appropriately (NVMe, MRRS, PCI, etc).
    > &gt;
    > &gt; End sentences with periods.
    > &gt;
    > &gt; A "move" patch must include both the removal and the addition and make
    > &gt; no changes to the code itself.
    > &gt;
    > &gt; Amlogic appears without explanation in 2/4. Must be separate patch to
    > &gt; address only that specific issue. Should reference published erratum
    > &gt; if possible. "Solves some issue" is not a compelling justification.
    > &gt;
    > &gt; The tree must be consistent and functionally the same or improved
    > &gt; after every patch.
    > &gt;
    > &gt; Add to pci_ids.h only if symbol used more than one place.
    > &gt;
    > &gt; See
    > &gt; https://lore.kernel.org/r/20210701074458.1809532-3-chenhuacai@loongson.cn,
    > &gt; which looks similar. Combine efforts if possible and cc Huacai so
    > &gt; you're both aware of overlapping work.
    > &gt;
    > &gt; More hints in case they're useful:
    > &gt; https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/
    > &gt;
    > &gt; &gt; Both ks_pcie_quirk loongson_mrrs_quirk was rewritten without any
    > &gt; &gt; functionality changes by one mrrs_limit_quirk
    > Does that means keystone and Loongson has the same MRRS problem? And what should I do now?
    >
    > Huacai
    > &gt; &gt;
    > &gt; &gt; Added DesignWare PCI controller which need same quirk for
    > &gt; &gt; * drivers/pci/controller/dwc/pci-meson.c (PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3)
    > &gt; &gt;
    > &gt; &gt; This quirk can solve some issue for Khadas VIM3/VIM3L(Amlogic)
    > &gt; &gt; with HDMI scrambled picture and nvme devices at intensive writing...
    > &gt; &gt;
    > &gt; &gt; come from:
    > &gt; &gt; * https://lore.kernel.org/linux-pci/20210618063821.1383357-1-art@khadas.com/
    > &gt; &gt;
    > &gt; &gt; Artem Lapkin (4):
    > &gt; &gt; PCI: move Keystone and Loongson device IDs to pci_ids
    > &gt; &gt; PCI: core: quirks: add mrrs_limit_quirk
    > &gt; &gt; PCI: keystone move mrrs quirk to core
    > &gt; &gt; PCI: loongson move mrrs quirk to core
    > &gt; &gt;
    > &gt; &gt; --
    > &gt; &gt; 2.25.1
    > &gt; &gt;
    >
    >
    > </chenhuacai@loongson.cn></email2tema@gmail.com></helgaas@kernel.org>

    \
     
     \ /
      Last update: 2021-07-05 10:36    [W:14.718 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site