lkml.org 
[lkml]   [2021]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.12 67/80] btrfs: abort transaction if we fail to update the delayed inode
    Date
    From: Josef Bacik <josef@toxicpanda.com>

    [ Upstream commit 04587ad9bef6ce9d510325b4ba9852b6129eebdb ]

    If we fail to update the delayed inode we need to abort the transaction,
    because we could leave an inode with the improper counts or some other
    such corruption behind.

    Signed-off-by: Josef Bacik <josef@toxicpanda.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/btrfs/delayed-inode.c | 8 ++++++++
    1 file changed, 8 insertions(+)

    diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
    index 2f73846d712f..55dad12a5ce0 100644
    --- a/fs/btrfs/delayed-inode.c
    +++ b/fs/btrfs/delayed-inode.c
    @@ -1066,6 +1066,14 @@ static int __btrfs_update_delayed_inode(struct btrfs_trans_handle *trans,
    btrfs_delayed_inode_release_metadata(fs_info, node, (ret < 0));
    btrfs_release_delayed_inode(node);

    + /*
    + * If we fail to update the delayed inode we need to abort the
    + * transaction, because we could leave the inode with the improper
    + * counts behind.
    + */
    + if (ret && ret != -ENOENT)
    + btrfs_abort_transaction(trans, ret);
    +
    return ret;

    search:
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-05 01:10    [W:3.103 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site