lkml.org 
[lkml]   [2021]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 4/5] ARM: Add basic support for EcoNet EN7523 SoC
    On Fri, Jul 30, 2021 at 3:45 PM Bert Vermeulen <bert@biot.com> wrote:
    >
    > From: John Crispin <john@phrozen.org>
    >
    > EN7523 is an armv7 based silicon used inside broadband access type devices
    > such as xPON and xDSL. It shares various silicon blocks with MediaTek
    > silicon such as the MT7622.
    >
    > Signed-off-by: John Crispin <john@phrozen.org>
    > Signed-off-by: Bert Vermeulen <bert@biot.com>

    It's always nice to see a new SoC family.

    > --- a/arch/arm/Kconfig
    > +++ b/arch/arm/Kconfig
    > @@ -580,6 +580,20 @@ config ARCH_VIRT
    > select HAVE_ARM_ARCH_TIMER
    > select ARCH_SUPPORTS_BIG_ENDIAN
    >
    > +config ARCH_ECONET
    > + bool "Econet SoC Support"
    > + depends on ARCH_MULTI_V7
    > + select ARM_AMBA
    > + select ARM_GIC
    > + select ARM_GIC_V3
    > + select ARM_DMA_USE_IOMMU
    > + select ARM_PSCI
    > + select HAVE_ARM_ARCH_TIMER
    > + select IOMMU_DMA
    > + select COMMON_CLK
    > + help
    > + Support for Econet EN7523 SoCs

    Given how closely related this probably is to MT7623/MT7622, should this
    perhaps just be part of arch/arm/mach-mediatek? According to
    https://wikidevi.wi-cat.ru/MediaTek#xPON, the older (mips based) MT752x
    chips are apparently just rebranded to EN752x after the business unit
    was spun off, but I guess they are still in the same family.

    > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
    > index 173da685a52e..1bff0aa29c07 100644
    > --- a/arch/arm/Makefile
    > +++ b/arch/arm/Makefile
    > @@ -152,6 +152,7 @@ textofs-$(CONFIG_ARCH_MSM8X60) := 0x00208000
    > textofs-$(CONFIG_ARCH_MSM8960) := 0x00208000
    > textofs-$(CONFIG_ARCH_MESON) := 0x00208000
    > textofs-$(CONFIG_ARCH_AXXIA) := 0x00308000
    > +textofs-$(CONFIG_ARCH_ECONET) := 0x00088000

    Why is this needed?

    Note also the comment directly above it exlaining
    # Text offset. This list is sorted numerically by address in order to
    # provide a means to avoid/resolve conflicts in multi-arch kernels.

    Arnd

    \
     
     \ /
      Last update: 2021-07-30 16:49    [W:2.401 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site