Messages in this thread | | | Date | Fri, 30 Jul 2021 06:28:52 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] bcm63xx_enet: simplify the code in bcm_enet_open() |
| |
On Thu, 29 Jul 2021 14:23:28 -0700 Florian Fainelli wrote: > On 7/29/21 12:06 AM, Tang Bin wrote: > > In the function bcm_enet_open(), 'ret = -ENOMEM' can be moved > > outside the judgement statement, so redundant assignments can > > be removed to simplify the code. > > > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > > Acked-by: Florian Fainelli <f.fainelli@gmail.com>
I wouldn't, the existing code is more robust IMO, but your call :)
Does not apply to net-next, please rebase.
| |