Messages in this thread | | | Date | Fri, 30 Jul 2021 17:42:56 -0700 | From | Jaegeuk Kim <> | Subject | Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option |
| |
On 07/31, Chao Yu wrote: > On 2021/7/31 7:41, Chao Yu wrote: > > On 2021/7/31 2:28, Jaegeuk Kim wrote: > > > how about adding "discard_gran=[small|segment|section]", and keeping discard_map > > > in the small case only? And, I think we should set the section mode for zoned > > > device automatically. > > > > Yup, better, > > > > About the naming, it look discard_gran is not clear here, since there is another > > sysfs entry /sys/fs/f2fs/<devname>/discard_granularity has the same name, and > > also semantics of newly added mount option is not only control the smallest discard > > size, but also indicate discard start offset should be aligned to segment or section. > > So how about using: "aligned_discard=[none|segment|section]" instead? > > Maybe: "aligned_discard=[block|segment|section]"?
How about discard_unit? I feel that issuing discards in one of those unit indicate the offset.
> > > > > Thanks, > > > > > > _______________________________________________ > > Linux-f2fs-devel mailing list > > Linux-f2fs-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > >
| |