Messages in this thread | | | Subject | Re: [PATCH] m68k: coldfire: return success for clk_enable(NULL) | From | Greg Ungerer <> | Date | Fri, 30 Jul 2021 16:56:36 +1000 |
| |
On 29/7/21 10:27 pm, Dan Carpenter wrote: > The clk_enable is supposed work when CONFIG_HAVE_CLK is false, but it > returns -EINVAL. That means some drivers fail during probe. > > [ 1.680000] flexcan: probe of flexcan.0 failed with error -22 > > Fixes: c1fb1bf64bb6 ("m68k: let clk_enable() return immediately if clk is NULL") > Fixes: bea8bcb12da0 ("m68knommu: Add support for the Coldfire m5441x.") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan. Applied to the m68knommu git tree, for-next branch, with Marc's Acked-by added.
Regards Greg
> --- > I can't actually compile test this, but it's correct. > > arch/m68k/coldfire/clk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/m68k/coldfire/clk.c b/arch/m68k/coldfire/clk.c > index 2ed841e94111..d03b6c4aa86b 100644 > --- a/arch/m68k/coldfire/clk.c > +++ b/arch/m68k/coldfire/clk.c > @@ -78,7 +78,7 @@ int clk_enable(struct clk *clk) > unsigned long flags; > > if (!clk) > - return -EINVAL; > + return 0; > > spin_lock_irqsave(&clk_lock, flags); > if ((clk->enabled++ == 0) && clk->clk_ops) >
| |