Messages in this thread Patch in this message | | | From | Phillip Potter <> | Subject | [PATCH 03/14] staging: r8188eu: remove ODM_RT_ASSERT macro definition and caller | Date | Sat, 31 Jul 2021 01:23:42 +0100 |
| |
Remove ODM_RT_ASSERT macro definition from include/odm_debug.h and its one caller in hal/odm.c, as this debug code is against best practice.
Signed-off-by: Phillip Potter <phil@philpotter.co.uk> --- drivers/staging/r8188eu/hal/odm.c | 1 - drivers/staging/r8188eu/include/odm_debug.h | 9 --------- 2 files changed, 10 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c index c6c184d95fee..fa3973393eda 100644 --- a/drivers/staging/r8188eu/hal/odm.c +++ b/drivers/staging/r8188eu/hal/odm.c @@ -1373,7 +1373,6 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate LowRSSIThreshForRA += GoUpGap; break; default: - ODM_RT_ASSERT(pDM_Odm, false, ("wrong rssi level setting %d !", *pRATRState)); break; } diff --git a/drivers/staging/r8188eu/include/odm_debug.h b/drivers/staging/r8188eu/include/odm_debug.h index 73fdea598707..c11d8925952c 100644 --- a/drivers/staging/r8188eu/include/odm_debug.h +++ b/drivers/staging/r8188eu/include/odm_debug.h @@ -96,15 +96,6 @@ RT_PRINTK fmt; \ } -#define ODM_RT_ASSERT(pDM_Odm, expr, fmt) \ - if (!(expr)) { \ - DbgPrint( "Assertion failed! %s at ......\n", #expr); \ - DbgPrint( " ......%s,%s,line=%d\n", __FILE__, \ - __func__, __LINE__); \ - RT_PRINTK fmt; \ - ASSERT(false); \ - } - void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm); #endif /* __ODM_DBG_H__ */ -- 2.31.1
| |