Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 29 Jul 2021 09:19:20 -0700 | Subject | Re: [PATCH v2 1/3] dt-bindings: nvmem: qfprom: Add optional power-domains property |
| |
Hi,
On Thu, Jul 29, 2021 at 5:01 AM Rajendra Nayak <rnayak@codeaurora.org> wrote: > > qfprom devices on some SoCs need to vote on the performance state > of a power-domain, so add the power-domains optional property to the > bindings > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org> > --- > Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > index 861b205..a498a08 100644 > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > @@ -51,6 +51,9 @@ properties: > vcc-supply: > description: Our power supply. > > + power-domains: > + description: A phandle to a power domain node. > +
I'm trying to channel my inner Rob here by saying that this description doesn't add anything and this should just be:
power-domains: maxItems: 1
Here's an example of Rob saying this:
https://lore.kernel.org/linux-devicetree/20210712151322.GA1931925@robh.at.kernel.org/
Other than that, feel free to add my "Reviewed-by" tag.
-Doug
| |