lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 023/108] perf test session_topology: Delete session->evlist
    Date
    From: Riccardo Mancini <rickyman7@gmail.com>

    [ Upstream commit 233f2dc1c284337286f9a64c0152236779a42f6c ]

    ASan reports a memory leak related to session->evlist while running:

    # perf test "41: Session topology".

    When perf_data is in write mode, session->evlist is owned by the caller,
    which should also take care of deleting it.

    This patch adds the missing evlist__delete().

    Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
    Fixes: c84974ed9fb67293 ("perf test: Add entry to test cpu topology")
    Cc: Ian Rogers <irogers@google.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Kan Liang <kan.liang@intel.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lore.kernel.org/lkml/822f741f06eb25250fb60686cf30a35f447e9e91.1626343282.git.rickyman7@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/perf/tests/topology.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/tools/perf/tests/topology.c b/tools/perf/tests/topology.c
    index 22daf2bdf5fa..f4a2c0df0954 100644
    --- a/tools/perf/tests/topology.c
    +++ b/tools/perf/tests/topology.c
    @@ -52,6 +52,7 @@ static int session_write_header(char *path)
    TEST_ASSERT_VAL("failed to write header",
    !perf_session__write_header(session, session->evlist, data.file.fd, true));

    + evlist__delete(session->evlist);
    perf_session__delete(session);

    return 0;
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-26 18:08    [W:4.155 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site