lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 1/1] media: ipu3-cio2: Drop reference on error path in cio2_bridge_connect_sensor()
    On Mon, Jul 26, 2021 at 02:55:51PM +0300, Andy Shevchenko wrote:
    > On Mon, Jul 26, 2021 at 2:47 PM Sakari Ailus
    > <sakari.ailus@linux.intel.com> wrote:
    > > On Mon, Jul 26, 2021 at 11:40:55AM +0300, Andy Shevchenko wrote:
    >
    > ...
    >
    > > > err_free_swnodes:
    > > > software_node_unregister_nodes(sensor->swnodes);
    > > > err_put_adev:
    > > > - acpi_dev_put(sensor->adev);
    > > > + acpi_dev_put(adev);
    > >
    > > adev is assigned to sensor->adev before goto so the two have the same
    > > value. I have no problem with the patch though.
    >
    > Are we reading the same version? Or am I missing something?

    I'm looking at the one in media-tree master.

    --
    Sakari Ailus

    \
     
     \ /
      Last update: 2021-07-26 14:02    [W:5.006 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site