lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] hwrng: Add Arm SMCCC TRNG based driver
On Mon, Jul 26, 2021 at 06:56:10PM +0100, Andre Przywara wrote:

> +static int smccc_trng_init(struct hwrng *rng)
> +{
> + return 0;
> +}

If this can be empty (looking at the core it seems like it can) then
best just remove it.

> + platform_set_drvdata(pdev, trng);
> + ret = devm_hwrng_register(&pdev->dev, trng);
> + if (!ret)
> + dev_info(&pdev->dev,
> + "ARM SMCCC TRNG firmware random number generator\n");

Is the log message needed given that we're not announcing any version
information here or anything? A brief sampling of other drivers
suggests it's not a standard thing for the subsystem.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-07-27 00:39    [W:0.047 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site