Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v2 3/3] scsi: qla2xxx: remove unused variable 'status' | From | Nathan Chancellor <> | Date | Mon, 26 Jul 2021 13:40:10 -0700 |
| |
On 7/26/2021 1:19 PM, 'Bill Wendling' via Clang Built Linux wrote: > Fix the clang build warning: > > drivers/scsi/qla2xxx/qla_nx.c:2209:6: error: variable 'status' set but not used [-Werror,-Wunused-but-set-variable] > int status = 0; > > Signed-off-by: Bill Wendling <morbo@google.com>
It has been unused since the function's introduction in commit a9083016a531 ("[SCSI] qla2xxx: Add ISP82XX support.").
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> --- > drivers/scsi/qla2xxx/qla_nx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c > index 615e44af1ca6..11aad97dfca8 100644 > --- a/drivers/scsi/qla2xxx/qla_nx.c > +++ b/drivers/scsi/qla2xxx/qla_nx.c > @@ -2166,7 +2166,6 @@ qla82xx_poll(int irq, void *dev_id) > struct qla_hw_data *ha; > struct rsp_que *rsp; > struct device_reg_82xx __iomem *reg; > - int status = 0; > uint32_t stat; > uint32_t host_int = 0; > uint16_t mb[8]; > @@ -2195,7 +2194,6 @@ qla82xx_poll(int irq, void *dev_id) > case 0x10: > case 0x11: > qla82xx_mbx_completion(vha, MSW(stat)); > - status |= MBX_INTERRUPT; > break; > case 0x12: > mb[0] = MSW(stat); >
| ![\](/images/icornerr.gif) |