lkml.org 
[lkml]   [2021]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 62/71] net: ti: fix UAF in tlan_remove_one
    Date
    From: Pavel Skripkin <paskripkin@gmail.com>

    commit 0336f8ffece62f882ab3012820965a786a983f70 upstream.

    priv is netdev private data and it cannot be
    used after free_netdev() call. Using priv after free_netdev()
    can cause UAF bug. Fix it by moving free_netdev() at the end of the
    function.

    Fixes: 1e0a8b13d355 ("tlan: cancel work at remove path")
    Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/ti/tlan.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/drivers/net/ethernet/ti/tlan.c
    +++ b/drivers/net/ethernet/ti/tlan.c
    @@ -314,9 +314,8 @@ static void tlan_remove_one(struct pci_d
    pci_release_regions(pdev);
    #endif

    - free_netdev(dev);
    -
    cancel_work_sync(&priv->tlan_tqueue);
    + free_netdev(dev);
    }

    static void tlan_start(struct net_device *dev)

    \
     
     \ /
      Last update: 2021-07-22 19:35    [W:2.539 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site