Messages in this thread | | | Date | Wed, 21 Jul 2021 22:34:24 +0530 | From | Sibi Sankar <> | Subject | Re: [PATCH v2 03/10] dt-bindings: remoteproc: qcom: Update Q6V5 Modem PIL binding |
| |
Hey Stephen,
Thanks for taking time to review the series.
On 2021-07-21 11:09, Stephen Boyd wrote: > Quoting Sibi Sankar (2021-07-20 03:12:53) >> diff --git >> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> index 494257010629..bc1394f5d677 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt >> @@ -198,6 +205,9 @@ For the compatible string below the following >> supplies are required: >> Definition: a phandle reference to a syscon representing TCSR >> followed >> by the three offsets within syscon for q6, modem >> and nc >> halt registers. >> + a phandle reference to a syscon representing TCSR >> followed >> + by the four offsets within syscon for q6, modem, >> nc and vq6 >> + halt registers on SC7280 SoCs. > > This seems to be duplicated? Maybe it should be combined with the > previous sentence and sc7280 called out?
yeah noticed ^^ but that's the style we've maintained till now. This would get cleanup up when I do the yaml conversion after the series lands.
> >> >> For the compatible strings below the following phandle references are >> required: >> "qcom,sc7180-mss-pil"
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
| |